Fix typo in absolute_pos_embed dimension check (C1 != C1 -> C1 != C2)#388
Open
Mr-Neutr0n wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix typo in absolute_pos_embed dimension check (C1 != C1 -> C1 != C2)#388Mr-Neutr0n wants to merge 1 commit intomicrosoft:mainfrom
Mr-Neutr0n wants to merge 1 commit intomicrosoft:mainfrom
Conversation
In `load_pretrained()`, the dimension mismatch guard for `absolute_pos_embed` compares `C1` with itself (`C1 != C1`), which is always False. This means a dimension mismatch between pretrained and current model embedding channels is never detected, leading to a confusing runtime error instead of a clear warning. The fix changes the comparison to `C1 != C2` so the check works as intended, matching the analogous check for `relative_position_bias_table` (which correctly uses `nH1 != nH2`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
utils.pyload_pretrained()where the dimension mismatch check forabsolute_pos_embedcomparesC1 != C1(alwaysFalse) instead of the intendedC1 != C2.relative_position_bias_tablecorrectly usesnH1 != nH2, confirming this is a typo.Test plan
C1->C2) matches the pattern used elsewhere in the same functionelsebranch executes either way)interpolate; now correctly logs a warning and skips