[Keyboard Manager] WinUI 3 Keyboard Manager #44305

zateutsch · 2025-12-16T04:34:12Z

Validation Steps

Running the Project

Option 1: Test via runner

Check out branch zt/new-kbm-localization
Build PowerToys project
Manually build Modules/KeyboardManagerEditorUI project separately
Run runner project
Ensure experimental features are enabled in general settings (should be on by default)
Launch keyboard manager via settings app

Option 2: Test via installer
Pending installer build is successful on this PR,

Install PowerToys via installer
Launch keyboard manager

Validation

For each page (Text, Remappings, Programs, URLs):

Create shortcuts with variable options and ensure they run as expected
Delete shortcuts and ensure they no longer execute
Try to create invalid shorcuts to check for proper validation
Ensure created shortcuts appear in Power Toys Settings Keyboard manager page
Any feedback on UI design appreciated as well

* Implement a dev version ui which is copy of current WinUI2 UX * Implement WinUI3 dropdown and P/Invoke the key list from existing C++ Library * Update Dllimport path

* Set up static new UX for Keyboard Manager Editor * Improve the formatting and performance * fix spelling

) * Load remapping config and data * display single key to shortcuts mapping properly * get remapping with operation type so we can display them in different tabs * clean up the xaml

* load URL remapping * Save Remapping Config and Data * update mock data for testing * fix app mapping * update xaml

* add press button * add right press button * add right press button by original button * change toggle button position * fix type error * merge * add link * brush blue in new keys * remove unuse annotations * remove unuse keyvisual

* Make Disable toggle button functional in Shortcuts page * Clean up main window and aggregate Constants * Update key remapping naming * Fix the key visual stretch out issue when the shortcut contains too many keys * Refactor code structure * fix wrapping in dialog * update naming * Implement Keyboard hook to get the user input of remappings * Implement Reset for InputControl to make sure InputControl can have correct status for various dialog

…oard Hook and Input Validator (#39081) * Add delete remapping function * Fix the problem that Keyboard Hook is not cleaned properly when the toggle button lost focus (user clicked other checkbox or switched to another app) * Make sure original toggle button is checked for InputControl * Disable app setting for single key remapping * Update KBM Editor UI Signing * Ensuring Modifier Keys Don't Repeat * Make sure the shortcut takes at most 4 modifier keys and show notification to the user * Show teaching tip for reserved illegal shortcuts - Win+L and Ctrl+Alt+Delete * Add validation to check if the user is trying to remap a key or shortcut that's already mapped for the same app context * Add validation to make sure key/shortcut cannot be mapped to itself * Add validation to check the original/new keys are not empty. Application name must be entered if the specific app checkbox is checked. * Add validation to check shortcuts must contain at least one action key in addition to modifier keys * Add validation to warn orphaned key to user * Unify and consolidate the validation code * Refactor the validation mechanism * Delete the existing remapping when user modified the content

…e-behind functionalities (#39888)  ## Summary of the Pull Request > [Target feature branch ``feature/KeyboardManagerWinUI3``] Refactor the New Keyboard Manager code to generalize functions (like Keyboard Hook) for use across pages. Implement Code-behind and the Text Remapping Page. - Implement the Text Remapping page - Restructure the Key Remappings code - Implement unified Keyboard Hook for all Pages - Implement Save and Delete for Text Page - Adjust the Text Page list UI - Create Input Control for Text Page - Validate the user input in Text Page and show teaching tip for the validation error - Move Remapping Saving into Helper - Move Remapping Delete into Helper - Don't check for duplicates if the original keys are the same as the remapping being edited - Use InputMode to indicate the active toggle for Original Keys/Remapped Keys - Add Rectangle for all pages ![image](https://github.com/user-attachments/assets/e109d82f-01c5-4da7-9efb-facea4070808) ![image](https://github.com/user-attachments/assets/09cc4462-43eb-4823-9b01-ab630a0bf9ed) ![image](https://github.com/user-attachments/assets/9b85c0f6-cbce-40cc-8e65-b755cb852eae) ![image](https://github.com/user-attachments/assets/ff7945cc-6535-4697-812e-93c2effab14e) ![image](https://github.com/user-attachments/assets/7cf887c8-24f3-45bd-956f-b3d655844974) ![image](https://github.com/user-attachments/assets/d958bb16-66b9-44e0-8918-32ddcc780f02)

This reverts commit 0009bbf.

remove ref to programs and url pages

…t/PowerToys into zt/new-kbm-localization

…xt page resource keys

src/modules/keyboardmanager/KeyboardManagerEditorUI/Helpers/ValidationHelper.cs

+            return ValidationErrorType.NoError;
+        }
+
+        // Temporary program shorctut validation


src/modules/keyboardmanager/KeyboardManagerEditorUI/Interop/KeyboardMappingService.cs

+            return KeyboardManagerInterop.AddShortcutRemap(_configHandle, originalKeys, targetKeys, targetApp, (int)operationType);
+        }
+
+        public bool AddShorcutMapping(ShortcutKeyMapping shortcutKeyMapping)


src/modules/keyboardmanager/KeyboardManagerEditorUI/Pages/Programs.xaml.cs

+            try
+            {
+                _mappingService = new KeyboardMappingService();
+                LoadProgramShrotcuts();


src/modules/keyboardmanager/KeyboardManagerEditorUI/Pages/Programs.xaml.cs

+            Dispose();
+        }
+
+        private void LoadProgramShrotcuts()


src/modules/keyboardmanager/KeyboardManagerEditorUI/Pages/Programs.xaml.cs

+                    Elevation = elevationLevel,
+                };
+
+                saved = _mappingService.AddShorcutMapping(shortcutKeyMapping);


src/modules/keyboardmanager/KeyboardManagerEditorUI/Strings/en-US/Resources.resw

+  <data name="RemappingsPageOriginalKeysTextBlock.Text" xml:space="preserve">
+    <value>Original key(s)</value>
+  </data>
+  <data name="RemmapingsPageOrphanedKeysTeachingTip.ActionButtonContent" xml:space="preserve">


src/modules/keyboardmanager/KeyboardManagerEditorUI/Strings/en-US/Resources.resw

+  <data name="RemmapingsPageOrphanedKeysTeachingTip.ActionButtonContent" xml:space="preserve">
+    <value>Continue anyway</value>
+  </data>
+  <data name="RemmapingsPageOrphanedKeysTeachingTip.CloseButtonContent" xml:space="preserve">


src/modules/keyboardmanager/KeyboardManagerEditorUI/Strings/en-US/Resources.resw

+  <data name="RemmapingsPageOrphanedKeysTeachingTip.CloseButtonContent" xml:space="preserve">
+    <value>Cancel</value>
+  </data>
+  <data name="RemmapingsPageOrphanedKeysTeachingTip.Title" xml:space="preserve">


src/modules/keyboardmanager/KeyboardManagerEditorUI/Strings/en-US/Resources.resw

+  <data name="TextPageInputControlTextContentTextBox.Header" xml:space="preserve">
+    <value>Text to insert</value>
+  </data>
+  <data name="TextPageDeleteButton.ToolTipSevice.ToolTip" xml:space="preserve">


src/settings-ui/Settings.UI/ViewModels/KeyboardManagerViewModel.cs

+                ProcessStartInfo startInfo = new ProcessStartInfo(path);
+                startInfo.UseShellExecute = true; // LOAD BEARING
+                startInfo.Arguments = $"{type.ToString(CultureInfo.InvariantCulture)} {Environment.ProcessId}";
+                System.Environment.SetEnvironmentVariable("MICROSOFT_WINDOWSAPPRUNTIME_BASE_DIRECTORY", null);


github-actions · 2025-12-16T04:38:28Z

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (6)

Remmapings
Sevice
shorctut
Shorcut
Shrotcuts
WINDOWSAPPRUNTIME

These words are not needed and should be removed

CLITo CVS Notavailable toolgood Uninitializes

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the [email protected]:microsoft/PowerToys.git repository
on the zt/new-kbm-localization branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/c635c2f3f714eec2fcf27b643a1919b9a811ef2e/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/20256621830/attempts/1' &&
git commit -m 'Update check-spelling metadata'

If the flagged items are 🤯 false positives

If items relate to a ...

binary file (or some other file you wouldn't want to check at all).

Please add a file path to the excludes.txt file matching the containing file.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).
well-formed pattern.

If you can write a pattern that would match it,
try adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.

haoliuu and others added 30 commits February 27, 2025 15:42

Initial commit: Have the WinUI3 Editor up and run

b2dae5b

[FHL] Set up dev UX for Keyboard Manager Editor (#37730)

d90215e

* Implement a dev version ui which is copy of current WinUI2 UX * Implement WinUI3 dropdown and P/Invoke the key list from existing C++ Library * Update Dllimport path

[FHL] New static UX for Keyboard Manager Editor (#37747)

f7ed043

* Set up static new UX for Keyboard Manager Editor * Improve the formatting and performance * fix spelling

[FHL] Load Remapping Config and Data for Keyboard Manager new UX (#37762

1e3108e

) * Load remapping config and data * display single key to shortcuts mapping properly * get remapping with operation type so we can display them in different tabs * clean up the xaml

[FHL] Save Remapping Config and Data (#37787)

e52ac85

* load URL remapping * Save Remapping Config and Data * update mock data for testing * fix app mapping * update xaml

[FHL] Add Select Key UI in Inputcontrol (#37788)

e184808

* add press button * add right press button * add right press button by original button * change toggle button position * fix type error * merge * add link * brush blue in new keys * remove unuse annotations * remove unuse keyvisual

Design tweaks and XAML refactoring

85dea93

Merge the new WinUI3 Keyboard Manager FHL change into feature branch

4f4bcbf

Merge branch 'main' into feature/KeyboardManagerWinUI3

c641fd1

Merge branch 'main' into feature/KeyboardManagerWinUI3

ed8b9c6

Merge branch 'main' into feature/KeyboardManagerWinUI3

3e69b2a

Localization finally working, remappings page done

5d83743

add remaining kbm localization strings

2ef9e65

remove reg key check

3ca59b5

fix xaml formatting

9c3fb1e

fix merge conflict

885ec89

version update

bbbc39c

Merge branch 'main' into zt/new-kbm-localization

044fc73

UX tweaks and restructuring of folders

2b7d699

Adding mouse UX, we can disable it later

0009bbf

Merge branch 'main' into zt/new-kbm-localization

9fe2ca2

update launch window size

cfe71c9

Merge branch 'main' into zt/new-kbm-localization

d6984b1

Revert "Adding mouse UX, we can disable it later"

0bdf3dc

This reverts commit 0009bbf.

update kbm output dir

b7dc354

Merge branch 'main' into zt/new-kbm-localization

9c8c41e

Using WinUIEx for windowing and other UX tweaks

7ddfbe5

zateutsch added 18 commits September 11, 2025 11:15

Update MainWindow.xaml

a2a1281

remove ref to programs and url pages

Merge branch 'zt/new-kbm-localization' of https://github.com/microsof…

7afdb97

…t/PowerToys into zt/new-kbm-localization

re add url and apps tab

3ab7b54

programs work

98c33fe

programs and urls now both working

6374241

Fixed localization bug (thanks Dustin), validated all working with Te…

05e1f7b

…xt page resource keys

text page input control localizaton

b369132

localization fix for remappings page

4eb42fe

Merge branch 'main' into zt/new-kbm-localization

c7fc697

Add package version for CommunityToolkit.WinUI.UI.Controls.Markdown

97131c8

Apply xaml styling + add conditional for pruning bug in VS2026

6b3c4a7

add extra package to notice

85f5bd9

update kbm output dir

b89e3ff

fix final few localization things, fix some xaml

2f8c214

Merge branch 'main' into zt/new-kbm-localization

5bec042

some xaml updates to app page input control

1f1eb33

xaml formatting

8de36e4

Fix program inout control xaml

255d5a0

zateutsch added the Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager label Dec 16, 2025

github-advanced-security bot found potential problems Dec 16, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Keyboard Manager] WinUI 3 Keyboard Manager #44305

[Keyboard Manager] WinUI 3 Keyboard Manager #44305

Uh oh!

zateutsch commented Dec 16, 2025 •

edited by niels9001

Loading

Uh oh!

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

github-actions bot commented Dec 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[Keyboard Manager] WinUI 3 Keyboard Manager #44305

Are you sure you want to change the base?

[Keyboard Manager] WinUI 3 Keyboard Manager #44305

Uh oh!

Conversation

zateutsch commented Dec 16, 2025 • edited by niels9001 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Validation Steps

Running the Project

Validation

Uh oh!

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

github-actions bot commented Dec 16, 2025

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (6)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

zateutsch commented Dec 16, 2025 •

edited by niels9001

Loading