ESLint flat config migration: diff review (old .eslintrc.cjs → new eslint.config.mts)#26554
Open
tylerbutler wants to merge 1 commit intolint/baseline-flat-config-migrationfrom
Open
Conversation
Replace old .eslintrc.cjs content with the new eslint.config.mts content from the preserve-eslint-comments branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dummy PR for reviewing the ESLint 8 → 9 flat config migration diff.
The base branch has each
eslint.config.mtsfile populated with the old.eslintrc.cjscontent from before the migration. The head branch has the new flat config content frompreserve-eslint-comments. The diff shows the actual content delta: old CJS format → new MTS flat config format.Related to PR #26211 (
preserve-eslint-comments).Caution
DO NOT MERGE — this PR exists only for diff review purposes.
How this works
Two synthetic branches are used:
lint/baseline-flat-config-migration): full repo tree with old.eslintrc.cjscontent written intoeslint.config.mtsfilenameslint/review-flat-config-migration): same tree but with the real neweslint.config.mtscontent frompreserve-eslint-commentsThe diff between them shows exactly 189 eslint config files changing from old format to new format.
Old content comes from commit
7a050c95(before the flat config migration). The scriptscripts/generate-baseline-eslint-configs.mjsautomates the baseline generation.Regeneration workflow
When
preserve-eslint-commentsis updated:Review notes
preserve-eslint-commentsbranch, then this PR regenerated.examples/data-objects/text-editor/eslint.config.mts) has no old equivalent and appears unchanged.