Add logLevel property to telemetry events#26548
Draft
MarioJGMsoft wants to merge 7 commits intomicrosoft:mainfrom
Draft
Add logLevel property to telemetry events#26548MarioJGMsoft wants to merge 7 commits intomicrosoft:mainfrom
MarioJGMsoft wants to merge 7 commits intomicrosoft:mainfrom
Conversation
MarioJGMsoft
changed the title
jason-ha
reviewed
Feb 26, 2026
Contributor
jason-ha
left a comment
jason-ha
left a comment
There was a problem hiding this comment.
We're replacing LogLevel with string? Any string is okay?
How are we documenting to our customers what they should be checking?
| sequenceNumber: number, | ||
| forceSend: boolean = false, | ||
| reason?: string, | ||
| logLevel?: string, |
Contributor
There was a problem hiding this comment.
not required?
If not specified, I think we'll emit undefined. Does undefined just get dropped?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a new optional logLevel property to telemetry events to indicate their importance for diagnostics. This enables consumers to make sampling or filtering decisions based on the event's importance level.
The property can have three values:
Events without a
logLevelvalue should be treated as essential.Reviewer Guidance
The goal is to eventually replace the existing LogLevel type with this new property. I'd appreciate feedback on the naming of the property and its values and whether the default behavior (treating missing logLevel as essential) makes sense.
The review process is outlined on this wiki page.