Remove old unused adapter types in tree#26540
Open
CraigMacomber wants to merge 1 commit intomicrosoft:mainfrom
Open
Remove old unused adapter types in tree#26540CraigMacomber wants to merge 1 commit intomicrosoft:mainfrom
CraigMacomber wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes unused adapter-related types from the tree DDS that were stubbed out during initial development but never implemented or used. The removed types (TreeAdapter, Adapters, and AdaptedViewSchema) were intended for schema adaptation functionality, but alternative design approaches have since been adopted making these types unnecessary.
Changes:
- Deleted the entire
schema-viewdirectory containing unused adapter types - Removed exports of these types from the core index file
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/dds/tree/src/core/schema-view/view.ts | Deleted file containing TreeAdapter interface, Adapters interface, and AdaptedViewSchema class definitions |
| packages/dds/tree/src/core/schema-view/index.ts | Deleted file that exported the adapter types |
| packages/dds/tree/src/core/schema-view/README.md | Deleted documentation file for the schema-view directory |
| packages/dds/tree/src/core/index.ts | Removed re-exports of the deleted adapter types |
Contributor
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove old unused adapter types in tree.
I stubbed these out when the tree code was originally written and they were never used.
We have since taken design approaches that make supporting them impractical and have alternatives, so they should be removed.
Reviewer Guidance
The review process is outlined on this wiki page.