Skip to content

Remove old unused adapter types in tree#26540

Open
CraigMacomber wants to merge 1 commit intomicrosoft:mainfrom
CraigMacomber:adapterGone
Open

Remove old unused adapter types in tree#26540
CraigMacomber wants to merge 1 commit intomicrosoft:mainfrom
CraigMacomber:adapterGone

Conversation

@CraigMacomber
Copy link
Contributor

@CraigMacomber CraigMacomber commented Feb 25, 2026

Description

Remove old unused adapter types in tree.
I stubbed these out when the tree code was originally written and they were never used.
We have since taken design approaches that make supporting them impractical and have alternatives, so they should be removed.

Reviewer Guidance

The review process is outlined on this wiki page.

Copilot AI review requested due to automatic review settings February 25, 2026 18:39
@CraigMacomber CraigMacomber requested a review from a team as a code owner February 25, 2026 18:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes unused adapter-related types from the tree DDS that were stubbed out during initial development but never implemented or used. The removed types (TreeAdapter, Adapters, and AdaptedViewSchema) were intended for schema adaptation functionality, but alternative design approaches have since been adopted making these types unnecessary.

Changes:

  • Deleted the entire schema-view directory containing unused adapter types
  • Removed exports of these types from the core index file

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/dds/tree/src/core/schema-view/view.ts Deleted file containing TreeAdapter interface, Adapters interface, and AdaptedViewSchema class definitions
packages/dds/tree/src/core/schema-view/index.ts Deleted file that exported the adapter types
packages/dds/tree/src/core/schema-view/README.md Deleted documentation file for the schema-view directory
packages/dds/tree/src/core/index.ts Removed re-exports of the deleted adapter types

@github-actions
Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  257792 links
    1822 destination URLs
    2063 URLs ignored
       0 warnings
       0 errors


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants