Remove Transactor.isInProgress#26535
Merged
noencke merged 1 commit intomicrosoft:mainfrom Feb 25, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the now-redundant isInProgress() method from the Transactor interface and converts size() from a method to a property. Since isInProgress() was semantically equivalent to size > 0, all usages have been replaced with direct size comparisons.
Changes:
- Removed
Transactor.isInProgress()method from the interface - Converted
Transactor.size()from a method to a property getter - Updated all call sites to check
size === 0orsize > 0instead of callingisInProgress() - Updated documentation comments to reference
Transactor.sizeinstead ofTransactor.isInProgress()
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/dds/tree/src/shared-tree-core/transaction.ts | Removed isInProgress() method, converted size() to property getter, updated documentation comments |
| packages/dds/tree/src/shared-tree/treeCheckout.ts | Replaced isInProgress() calls with size === 0 or size > 0 checks |
| packages/dds/tree/src/shared-tree/sharedTree.ts | Replaced isInProgress() calls with size === 0 or size > 0 checks |
| packages/dds/tree/src/shared-tree/schematizingTreeView.ts | Replaced isInProgress() call with size > 0 check |
| packages/dds/tree/src/test/shared-tree/treeCheckout.spec.ts | Updated test assertions to check size property values directly |
| packages/dds/tree/src/test/shared-tree-core/transaction.spec.ts | Updated test assertions to use size property instead of isInProgress() and size() method |
| packages/dds/tree/src/test/shared-tree/fuzz/fuzzEditReducers.ts | Replaced isInProgress() calls with size property checks |
| packages/dds/tree/src/test/shared-tree/fuzz/fuzzEditGenerators.ts | Replaced isInProgress() calls with size > 0 checks |
daesunp
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup PR that replaces the now-redundant
isInProgresswith checks againstsize.Transactor.sizehas also been made a property rather than a method.