Add TestFailingCompletionHandlerCrashesProcess Test#2309
Open
kythant wants to merge 2 commits intostaging/3.0from
Open
Add TestFailingCompletionHandlerCrashesProcess Test#2309kythant wants to merge 2 commits intostaging/3.0from
kythant wants to merge 2 commits intostaging/3.0from
Conversation
Sergio0694
reviewed
Mar 2, 2026
| await Task.Delay(TimeSpan.FromSeconds(5)); | ||
|
|
||
| // If we get here, the process survived the throwing completion handler. | ||
| Assert.IsTrue(true, "Process survived the throwing native completion handler."); |
Member
There was a problem hiding this comment.
So like, if this test passes it means that either:
- The test is somehow wrong
- Something else is wrong 😆
@manodasanW this code should (intentionally) crash the process, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.