filter out URLs before finding hashtags#38
Closed
emilypastewka wants to merge 2 commits intomfarragher:devfrom
Closed
filter out URLs before finding hashtags#38emilypastewka wants to merge 2 commits intomfarragher:devfrom
emilypastewka wants to merge 2 commits intomfarragher:devfrom
Conversation
Owner
|
@emilypastewka I've take your commits from this PR and brought in the latest changes from the I'm not sure why but there are a few tests failing. I'll close this PR but do continue any changes in that newer PR. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
Because URLs can have
#in them, components of URLs were getting pulled in as tagswhat changes
get_tagsto pull URLs out of the note text before extracting tags#in it to the test md that's used to testget_tags