Skip to content

Conversation

@robll-v1
Copy link
Collaborator

What type of PR is this?

  • API-change
  • [ ✅] BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #14490

What this PR does / why we need it:

Fixes tuple IN/NOT IN handling in the binder so row constructors like (a,b) IN ((1,2),(3,4)) no longer fall back to scalar IN and error. Adds SQL and Go tests to prevent regressions.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@aunjgr aunjgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要加一些带null值的测试。根据过去经验,对null值的处理最容易出错。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Something isn't working size/M Denotes a PR that changes [100,499] lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants