Skip to content

Conversation

@divyesh-git22
Copy link

This PR refactors the Pre-Install Checks UI to use a scrollable Panel
instead of fixed positioning.
what this change does:

  • Prevents UI overflow on smaller screens
  • Removes dependency on manual spacing
    No installer logic was changed by myside

@google-cla
Copy link

google-cla bot commented Dec 26, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@emtuls
Copy link
Member

emtuls commented Jan 5, 2026

Thank you for the PR @divyesh-git22!

I am testing the PR on Windows 10 and I did notice some issues that need to be addressed:

  1. The Pre-Install Checks window seems to be broken:
    Scroll wheels have been added to the sides, which is a great change! But unfortunately, some other things broke in the process:
  • The checkbox we had to ensure users have made a snapshot before continuing seems to be missing.
  • The Continue and Cancel boxes seem to be missing.
  • The True and False indicators next to each check also seem to be missing.

Your code:
image
image

This is how I would expect it to look when fixed:
image

  1. The internet connectivity checks seem to have been removed:

Before (original code):
image

After (your PR):
image

  1. The package selection window still doesn't include the scroll bars on the sides, which I believe was the main concern from Flare-VM Package Installation Windows UI Issue #737

Your code (note there are no scroll wheels on the sides for lower resolutions):
image

This is how I would expect it to look when fixed:
image

@emtuls emtuls self-requested a review January 5, 2026 22:08
@emtuls emtuls added the 🐛 bug Something isn't working label Jan 5, 2026
Copy link
Member

@emtuls emtuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants