Implementation of the module for the sensor "SGP30"#199
Open
vrubel wants to merge 5 commits intoloboris:masterfrom
Open
Implementation of the module for the sensor "SGP30"#199vrubel wants to merge 5 commits intoloboris:masterfrom
vrubel wants to merge 5 commits intoloboris:masterfrom
Conversation
Owner
|
Thank you for the PR. I would propose to make the MicroWebSrv related PRs directly to the original repository. I'll look at the proposed SGP30 module. Generally, there are so many I2C sensors that it would be impossible to make the drivers/modules for all of them. Maybe it would be more useful and interesting to create the driver/module in Python, that way the users can learn something analizyng the code (and modify it if necessary) and the performance is usually more tha enough for most I2C devices. |
…_psRAM_LoBo # Conflicts: # MicroPython_BUILD/components/micropython/Kconfig.projbuild
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if your policy allows to create submodules. Please look at the proposed changes. If the existence of submodules is unacceptable, I will be ready to suggest an option with copies of files from the vendor's repository.