This repository was archived by the owner on Aug 8, 2025. It is now read-only.
Measure elapsed time after function call#130
Open
lihu-zhong wants to merge 2 commits intolitl:masterfrom
Open
Conversation
added 2 commits
July 21, 2021 15:12
When I specify the `max_time` argument, I expect the worst-case upper bound for execution time to be the specified timeout + the execution time of a single function call. Moreover, I would not expect retries to trigger if the give up condition is already fulfilled after the first function execution. The existing behavior appears to be caused by collected `elapsed` for the `details` before the target function is executed. Both of the above bugs should be fixed by swapping that ordering.
|
This would have addressed #186 |
|
I forked the library as https://github.com/Kirusi/improved_backoff. If you depend on properly working |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes what I consider to be unexpected behavior:
Steps to reproduce
Observed behavior
Expected behavior
When I specify the
max_timeargument, I expect the worst-case upper bound for execution time to be the specified timeout + the execution time of a single function call. Moreover, I would not expect retries to trigger if the give up condition is already fulfilled after the first function execution.This behavior appears to be caused by collected
elapsedfor thedetailsbefore the target function is executed. This patch should fix both of the above bugs by swapping that ordering.