Skip to content

Conversation

@tawera-manaena
Copy link
Contributor

@tawera-manaena tawera-manaena commented Jan 26, 2026

The work is done. I just need to updated the description to capture another bug corrected by this work.


This pull request also resolves BM-1476.

Motivation

This ticket addresses a few URL-based issues.

  1. We recently deployed our new diff command to handle basemaps-config QA preview links. However, we’ve since discovered a minor bug with our vector preview links. Those of which concern the projection parameter.

  2. Through the above, we discovered that our landing package does not support the long form of the projection parameter. The long form being projection=, and the short form being p=.

  3. In addition, there are some issues with the preview links generated by our create-config command. We use these links to support our Slack-based QA, such as the messages posted in our alert-argo-workflows channel. Currently, certain preview links are missing the pipeline parameter.

Modifications

  • packages/cli-config/src/cli/

    • diff/

      • config.diff.markdown.ts

        • TBC
    • action.create.config.ts

      • TBC
  • packages/landing/src/

    • config.map.ts

      • TBC

Verification

I have a few things to verify:

  • basemaps-config QA

    • I need to verify that the preview links for our topographic-v2 vector tileset preserve the given tile matrix (formerly projection), either: WebMercatorQuad, or NZTM2000Quad.
  • packages/landing

    • I need to run basemaps locally to check that our system preserves URLs containing the long form of the projection parameter.
  • Slack-based QA

    • I need to find and re-run an Argo Workflow that generated broken preview links , by way of the create-config command.

@tawera-manaena tawera-manaena changed the title fix(cli-config): use searchParams strategy for config preview urls BM-1407 fix(cli-config): Argo workflow preview URLs BM-1407 Jan 26, 2026
@tawera-manaena tawera-manaena added the container build pull request container for testing label Jan 27, 2026
@tawera-manaena tawera-manaena changed the title fix(cli-config): Argo workflow preview URLs BM-1407 fix(cli-config): QA preview URLs BM-1407 Jan 27, 2026
@tawera-manaena
Copy link
Contributor Author

tawera-manaena commented Jan 28, 2026

Verification

# from .../packages/cli/build/cli/

> node bin.js config diff --before before.json.gz --after after.json.gz --output changes.md
  • Fixed the tileset preview links
  • Fixed the NZTM2000Quad vector preview links

I've removed the config parameter from the URLs as I generated this locally. They should still work, pointing to prod.


Configuration changes detected

Key: ➕ New | 🔄 Updated | 🗑️ Deleted

Aerial layer

One or more changes has been detected on the primary aerial imagery layer

🔄 Aerial Imagery Basemap (ts_aerial) 🌏 | 🗺️

  • ➕ Bay of Plenty 0.1m Urban Aerial Photos (2025) - Draft (bay-of-plenty-2025-0.1m) 🌏 | 🗺️

Tilesets

🔄 Updated

🔄 Elevation (ts_elevation)

  • 🎨 color-ramp: 🌏 | 🗺️
  • ⛰️ terrain-rgb: 🌏 | 🗺️
  • 🔄 Auckland Part 1 LiDAR 1m DEM (2024) (auckland-part-1_2024_dem_1m)

    • 🎨 color-ramp: 🌏 | 🗺️
    • ⛰️ terrain-rgb: 🌏 | 🗺️
    • 🔄 .3857: "im_01JRVM0Y6F002XK2VCF971C5AB" -> "im_01KFC1AQFFBKC7FKT81DYZSWWG"
  • 🔄 Auckland Part 2 LiDAR 1m DEM (2024) (auckland-part-2_2024_dem_1m)

    • 🎨 color-ramp: 🌏 | 🗺️
    • ⛰️ terrain-rgb: 🌏 | 🗺️
    • 🔄 .3857: "im_01JZ6M3QG5A72HS1R6HJ20QHD0" -> "im_01KFC0VVSB79R3RDQKDHJGZHGE"

➕ New

➕ Gisborne 0.6m SN12490B (1997) (ts_gisborne-sn12490b-1997-0.6m) 🌏 | 🗺️

Vector Data Update

Tilesets

🔄 topographic-v2

Feature updates for topographic-v2

🟦 105689-nz-addresses-pilot - version: 430324 (from: 429794) features: 2402386 (+747)
🟦 50772-nz-primary-parcels - version: 430224 (from: 429696) features: 2775852 (+644)

Vector Tile Analyse Report for WebMercatorQuad

🟩 WebMercatorQuad(Click to Expand) 🟩 Ommited

Vector Tile Analyse Report for NZTM2000Quad

🟩 NZTM2000Quad(Click to Expand) 🟩 Ommited

🔄 topographic

Feature updates for topographic

🟦 50772-nz-primary-parcels - version: 430224 (from: 429696) features: 2775852 (+644)
🟦 105689-nz-addresses-pilot - version: 430324 (from: 429794) features: 2402386 (+747)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

container build pull request container for testing

Development

Successfully merging this pull request may close these issues.

3 participants