-
Notifications
You must be signed in to change notification settings - Fork 19
fix(cli-config): QA preview URLs BM-1407 #3595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Verification# from .../packages/cli/build/cli/
> node bin.js config diff --before before.json.gz --after after.json.gz --output changes.md
I've removed the Configuration changes detectedKey: ➕ New | 🔄 Updated | 🗑️ Deleted Aerial layerOne or more changes has been detected on the primary aerial imagery layer 🔄 Aerial Imagery Basemap (
|
The work is done. I just need to updated the description to capture another bug corrected by this work.
This pull request also resolves BM-1476.
Motivation
This ticket addresses a few URL-based issues.
We recently deployed our new
diffcommand to handle basemaps-config QA preview links. However, we’ve since discovered a minor bug with our vector preview links. Those of which concern theprojectionparameter.Through the above, we discovered that our landing package does not support the long form of the
projectionparameter. The long form beingprojection=, and the short form beingp=.In addition, there are some issues with the preview links generated by our
create-configcommand. We use these links to support our Slack-based QA, such as the messages posted in ouralert-argo-workflowschannel. Currently, certain preview links are missing thepipelineparameter.Modifications
packages/cli-config/src/cli/
diff/
config.diff.markdown.tsaction.create.config.tspackages/landing/src/
config.map.tsVerification
I have a few things to verify:
basemaps-config QA
topographic-v2vector tileset preserve the given tile matrix (formerly projection), either:WebMercatorQuad, orNZTM2000Quad.packages/landing
projectionparameter.Slack-based QA
create-configcommand.