ci: tox-lsr 3.17.1 - previous update broke container tests, this fixes them [citest_skip]#200
Merged
ci: tox-lsr 3.17.1 - previous update broke container tests, this fixes them [citest_skip]#200
Conversation
…s them [citest_skip] tox-lsr 3.17.1 has a fix for the broken container tests There was one shell function for both setting up the callback plugins and the connection plugin. When this function was skipped, the ANSIBLE_CONNECTION_PLUGINS environment variable was not set, so all subsequent tests failed. The connection plugin must be present and the env. var. must be set in order to run any container tests. The code was fixed to ensure that there is always a connection plugin installed in the correct location and that ANSIBLE_CONNECTION_PLUGINS is always set and contains this path. Also, setting up the callback plugins and the connection plugin is already idempotent, so no reason to skip them. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates GitHub Actions workflows to use tox-lsr 3.17.1 and adjusts the qemu-kvm integration test script to always set up the required Ansible connection plugin by no longer skipping callback/connection plugin setup between test runs, plus a minor YAML shell indentation fix. Sequence diagram for container test setup with tox_lsr_3_17_1sequenceDiagram
actor Dev as Developer
participant GA as GitHub_Actions_job
participant Tox as tox_lsr_3_17_1
participant CT as Container_tests
participant CP as Connection_plugin
participant ENV as Env_vars
Dev->>GA: Push_changes_triggers_CI
GA->>Tox: Run_container_test_env_setup
Tox->>CP: Ensure_connection_plugin_installed
CP-->>Tox: Connection_plugin_path
Tox->>ENV: Set_ANSIBLE_CONNECTION_PLUGINS_with_plugin_path
ENV-->>Tox: Env_confirmed
Tox->>CT: Execute_container_tests_with_connection_plugin
CT-->>GA: Test_results_returned
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The tox-lsr version string is duplicated across multiple workflows; consider centralizing it via a reusable workflow, composite action, or a shared environment variable to make future version bumps less error-prone.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The tox-lsr version string is duplicated across multiple workflows; consider centralizing it via a reusable workflow, composite action, or a shared environment variable to make future version bumps less error-prone.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tox-lsr 3.17.1 has a fix for the broken container tests
There was one shell function for both setting up the callback plugins and the connection plugin.
When this function was skipped, the ANSIBLE_CONNECTION_PLUGINS environment variable was not
set, so all subsequent tests failed. The connection plugin must be present and the env. var.
must be set in order to run any container tests. The code was fixed to ensure that there is
always a connection plugin installed in the correct location and that ANSIBLE_CONNECTION_PLUGINS
is always set and contains this path.
Also, setting up the callback plugins and the connection plugin is already idempotent, so no
reason to skip them.
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Update CI workflows to use tox-lsr 3.17.1 and ensure container tests no longer skip required plugin setup.
Bug Fixes:
CI: