Open
Conversation
As per automake manual[1], DIST_SUBDIRS should be used to recurse into the subdirectories those we want to ship as part of make dist and use SUBDIRS for conditionally building the directories. Adopt this rule across the source. [1] https://www.gnu.org/software/automake/manual/html_node/SUBDIRS-vs-DIST_005fSUBDIRS.html Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Control the building and testing (make check) of the tests using the if/endif WITH_TESTS guard based on the configuration options passed. If the --enable-tests (default on) is passed during ./configure step, the SUBDIRS directories (ftests/gunit) are recused into build and make check are run. Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patchset, has two patches. Where the first one introduces DIST_SUBDIRS
to ship the directories/sub-directories as part of the tarball created using make dist*
and use SUBDIRS to add build conditions.
The second patch is built upon the usage of
DIST_SUBDIRS, where the buildingand testing
SUBDIRSdirectories (ftests/gunit) are guarded usingWITH_TESTSinthe top-level
Makefile.am. TheWITH_TESTSis passed when./configureis passed--enable-teststo theMakefile.