Move SMART info to hardwarehealth message #132
Conversation
europaul
requested review from
christoph-zededa
and removed request for
eriknordmark
ZInfoHardware will be used only as hardware inventory message and metrics such as ECC and SMART will be bundled in the hardware health message. Signed-off-by: Paul Gaiduk <[email protected]>
Add generate go and python code for info.proto and hardware_health.proto Signed-off-by: Paul Gaiduk <[email protected]>
europaul
force-pushed
the
move-smart-to-hardwarehealth
branch
from
ded103b to
46cf657
Compare
eriknordmark
left a comment
eriknordmark
left a comment
There was a problem hiding this comment.
LGTM but there is a yetus complaint on the markdown file.
It's just about a line being too long, but the line is actually shorter than a lot others in that section |
Sure, but the idea is to improve things by requiring PRs to follow the rules. FWIW I think that 80 is quite short as a limit. What length do we check for in the EVE repo? Makes sense having consistent checks across the repos. |
This makes the linting consistent with the EVE repo. Signed-off-by: Paul Gaiduk <[email protected]>
Turns out, we disabled that rule for markdownlinter on EVE. I added the same config here. |
2 participants
ZInfoHardware will be used only as hardware inventory message and metrics such as ECC and SMART will be bundled in the hardware health message.