Skip to content

Conversation

@tzoltak
Copy link

@tzoltak tzoltak commented Aug 7, 2019

  • [v] if suggesting code changes or improvements, open an issue first
  • [v] for all but trivial changes (e.g., typo fixes), add your name to DESCRIPTION
  • [v] for all but trivial changes (e.g., typo fixes), documentation your change in NEWS.md with a parenthetical reference to the issue number being addressed
  • [v] add code or new test files to /tests for any new functionality or bug fix
  • [v] make sure R CMD check runs without error before submitting the PR

This pull requests deals with #39 and #40 .

@leeper
Copy link
Owner

leeper commented Jun 20, 2020

Thanks or this and sorry for long delay in reviewing. Looks good to me. Can you rebase and resubmit (there are some merge conflicts)? If not, I'll try to get to it.

@tzoltak
Copy link
Author

tzoltak commented Jun 21, 2020

I can do this but within few weeks time.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants