chore: Use FDv1 DataSystem in the ldclient #345
Merged
+102
−133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
jsonbailey
commented
Dec 9, 2025
| # @return [Array<EvaluationDetail, [LaunchDarkly::Impl::Model::FeatureFlag, nil], [String, nil]>] | ||
| # | ||
| def variation_with_flag(key, context, default) | ||
| private def variation_with_flag(key, context, default) |
Contributor
Author
There was a problem hiding this comment.
The file used a mix of per method private and all methods after the declaration on line 717 of the original file. Moving to defining per method.
keelerm84
reviewed
Dec 16, 2025
| # | ||
| def initialized? | ||
| @config.offline? || @config.use_ldd? || @data_source.initialized? | ||
| @data_system.data_availability == @data_system.target_availability |
Member
There was a problem hiding this comment.
Are we sure these lines are equivalent given our previous discussions about this? I can't remember exactly where we landed on that.
Contributor
Author
There was a problem hiding this comment.
They should be equivalent for FDv1. This will need to be altered a bit when we introduce FDv2.
- Offline returns and expects
DEFAULTS✅ - Use_Ldd returns and expects
REFRESHED(because it uses null processor) ✅ - If the data_source.Initialized is true the data_system returns
REFRESHEDandCACHEDif false, but we expectREFRESHED✅
keelerm84
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adopt FDv1 data system in client
Impl::DataSystem::FDv1; FDv1 wraps the originalfeature_storeonce (avoids nested wrappers), injectsdata_source_update_sink, exposesstore,flag_change_broadcaster, and status providers, and cleans up viastop(includingstore_wrapper.stop).data_store_status_provideranddata_source_status_providerfrom LDClient to the data system; addflushdelegator to the event processor; refine SDK key nil validation for offline/LDD/custom sources.initialized?now comparesdata_availabilityvstarget_availability; all reads switched todata_system.storein evaluations andall_flags_state.Tests
spec/impl/data_system/fdv1_spec.rbcovering store wrapping (no nested wrappers), processor selection (streaming/polling/offline/LDD), custom data source factory/instance handling, start/stop idempotency, availability semantics, diagnostic accumulator integration, and provider/broadcaster access.Written by Cursor Bugbot for commit 59ae3c0. This will update automatically on new commits. Configure here.