Conversation
Tests under this class seem not to be run due to pytest discovery rules, which requires classes to be prefixed with Test. This also seems to be hiding potential problems with non-PostgreSQL database systems.
kurtmckee
left a comment
There was a problem hiding this comment.
TestDateRangeOnPostgres inherits from DateRangeTestCase.
https://github.com/SuibianP/sqlalchemy-utils/blob/patch-1/tests/types/test_date_range.py#L87
The class name needs to change in both places.
|
@SuibianP, thanks for your work on this. You were right -- making the tests discoverable has indeed revealed some issues. For posterity, here's the output from one of the failing tests on Python 3.7: Is this something you're comfortable debugging and resolving as a part of this PR? (By the way, the Python 3.6 deprecation failures are resolved in the most recent commits. If you rebase those should disappear and let you run the tests in Python 3.6.) |
|
@kurtmckee This issue roots from kvesteri/intervals#49, and will be automatically solved by bumping the dependency version once that PR is merged. On a separate note, the practice of de/serialising with |
Tests under this class seem not to be run due to pytest discovery rules, which requires classes to be prefixed with
Test.This also seems to be hiding potential problems with non-PostgreSQL database systems.