Fix missing ROM definitions in roms.plist#44
Open
anomixer wants to merge 1 commit intoksherlock:masterfrom
Open
Fix missing ROM definitions in roms.plist#44anomixer wants to merge 1 commit intoksherlock:masterfrom
anomixer wants to merge 1 commit intoksherlock:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Fix missing ROM definitions and suggest updated download URL
🔍 Symptom
When selecting certain machines in Ample—specifically the Macintosh PowerBook Duo 280, PowerBook Duo 280c, Pravetz 8C/82/8M, and TK3000 //e—the application reports missing firmwares. However, these ROMs cannot be found or downloaded through the built-in firmware manager because they are missing from the
roms.plistdefinitions, despite being correctly referenced inmodels.plist.🎯 Objective
This PR fixes this discrepancy by adding the missing ROM entries to
Ample/Resources/roms.plist. It ensures that all machines currently supported by the model definitions can actually be used by allowing the UI to identify and acquire their necessary firmwares. Additionally, we include a suggestion for the download source to improve overall reliability.🛠️ Changes in
Ample/Resources/roms.plistThe following system ROMs were defined in
models.plistbut missing from the firmware management list, preventing users from identifying or downloading required files via the UI.1. Macintosh Additions
macpd270c(around line 1636).macpd280(Macintosh PowerBook Duo 280).macpd280c.2. Apple II Clone & Sub-system Additions
ym2608(around line 2488).prav8c(Pravetz 8C)prav82(Pravetz 82)prav8m(Pravetz 8M)tk3000(TK3000 //e)prav8ckb(Pravetz 8C Keyboard)📝 Proposed XML Snippets
Location 1: PowerBook Duo Series
Location 2: Apple II Clones & Peripherals
🌐 Download URL Suggestion
Currently, Ample relies on
callapple.org. During testing for the Windows port, we observed that:callapple.orgsuccessfully covers the PowerBook Duo 280/280c ROMs.Therefore, we suggest adding:
https://mdk.cab/download/split/as a fallback URL. It provides complete coverage for these clones and more modern MAME split sets, ensuring a 100% success rate for all systems defined in the library.
You might also consider implementing a selectable URL list (similar to the AmpleWin port) that allows users to pick their preferred source (e.g., callapple + mdk.cab) or automatically failover between them for maximum reliability.
🎨 About the AmpleWin Port
This PR is submitted in conjunction with the development of AmpleWin, a precision Windows port of your project. You can explore the project and its detailed documentation here:
Our goal is to achieve near 100% UI fidelity and feature parity for Windows users. To maintain a clean integration, all Windows-specific logic, scripts, and binaries are strictly isolated within the
AmpleWin/subdirectory. We strive to keep the upstream root directory and resources untouched. We are only proposing these changes toAmple/Resources/roms.plistbecause they are functionally essential to allow all machines in the library to be fully "bootable" via the UI for all users.Thanks for your consideration.
Note: This PR content was prepared by Antigravity AI as part of the AmpleWin Windows port project.