DMD-375 add new suite paratest-snowflake-real-storage by zajca · Pull Request #1569 · keboola/storage-api-php-client

zajca · 2025-09-16T12:27:23Z

Jira: DMD-375
KBC: https://github.com/keboola/connection/pull/6203

Before asking for review make sure that:

Checklist

New client method(s) has tests
New client method(s) support branches, or they are listed in BranchAwareClient
Apiary file is updated

Release

I gave the PR a proper label:
- major (BC break)
- minor (new feature)
- patch (backwards compatible fix)
- no release (just test changes)

…-enable-tests

…ects-to-symfonye2 remove deprecated tests

PAT-178 ws keypair

…ucture-should-not-cause-internal-error DMD-92 Throw meaningful exception when view is out of sync

…ter-dmd-92 DMD-108 fix test issue from DMD-92

…n-for-sharing Roman/dmd 103 remove sync option for sharing

…-from-standard-external-buckets DMD-105 test im of tables from standard external buckets

github-actions · 2025-09-16T12:30:10Z

Created tag dev-test-1569-1.

github-actions · 2025-09-16T12:37:13Z

Created tag test-1569-1.

github-actions · 2025-09-16T12:40:19Z

Created tag test-1569-2.

fix messages assertions

- DMD-285 - "Profiled by" token in profiling response.

- DMD-285 - Add metric test because there was no "DataSizeTableMetric" available for Snowflake before.

- DMD-285

jirkasemmler

malickost

jirkasemmler · 2025-09-19T13:56:36Z

phpunit.xml.dist

 		<directory>tests/Backend/NetworkPolicies</directory>
 	</testsuite>
+    <testsuite name="paratest-snowflake-storage-branches">
+        <directory>tests/Backend/Features/RealReadOnlyBranches</directory>


to se mi libi, ze bychom to zacali trochu tridit podle features. Pri presunu do connection bychom v tom mohli udelat trochu vic poradek

jirkasemmler · 2025-09-19T14:01:41Z

tests/Backend/Features/RealReadOnlyBranches/SnowflakeRealBranchesTest.php

+         * @var array<array{name:string}> $schemas
+         */
+        //@phpstan-ignore-next-line
+        $schemas = $wsBackend->getDb()->fetchAllAssociative('SHOW SCHEMAS WITH PRIVILEGES USAGE;');


a bez toho WITH PRIVILEGES USAGE by to funovalo?

jop odstranil sem není potřeba to omezovat na práva

jirkasemmler · 2025-09-19T14:05:15Z

tests/Backend/Features/RealReadOnlyBranches/SnowflakeRealBranchesTest.php

+     *  3. Assert backendPath for both buckets.
+     *  4. Create workspace in default branch – ensure dev bucket NOT visible.
+     *  5. Create workspace in dev branch – ensure BOTH buckets visible.
+     *  6. Drop dev branch – ensure its bucket and workspace are deleted (no longer accessible).


chybi mi tam jeden case - vyrabis a operujes nad devbranchi X. Ale co jina branch Y, ktera by nemela videt bucket z branche X? V bode 4 to testujes jen default - dev. Ale tam se krizi projektova RO role a dev RO role. Myslim, ze potrebujeme case dev-dev

DMD-285 profiling metrics

jirkasemmler and others added 30 commits March 31, 2025 15:40

apiary

0f7ff97

Merge pull request #1481 from keboola/jirka/ct-1955-delete-rows-in-bq…

8ef907e

…-enable-tests

remove deprecated tests

9648660

Merge pull request #1482 from keboola/roman/dmd-64-move-share-to-proj…

a46f1c7

…ects-to-symfonye2 remove deprecated tests

add utils methods

6c92566

WorkspaceConnectionTrait support key pair

a1ac599

add support for snowflake-person-keypair

7c71d08

add snowflake-person-keypair test

3529892

add snowflake-service-keypair support

4147137

Merge pull request #1483 from keboola/zajca/pat-178/ws-keypair

0f7524a

PAT-178 ws keypair

DMD-92 Throw meaningful exception when view is out of sync

6af4612

Merge pull request #1486 from keboola/tf-DMD-92-sds-change-of-datastr…

51eda9c

…ucture-should-not-cause-internal-error DMD-92 Throw meaningful exception when view is out of sync

DMD-108 fix test issue from DMD-92

0ad52c7

Merge pull request #1491 from keboola/tf-DMD-108-fix-failing-tests-af…

8bc0ed5

…ter-dmd-92 DMD-108 fix test issue from DMD-92

remove unused deprecated shareBucket method

61e1c3e

remove async from client

a45e336

Update tests

dd20f10

Baseline

ea1c0a9

update apiary

1580837

Merge pull request #1492 from keboola/roman/dmd-103-remove-sync-optio…

2b2f565

…n-for-sharing Roman/dmd 103 remove sync option for sharing

DMD-105 test IM from table in standard EB

8ea038e

fix tests

65772c5

styling

ea0a2d0

Merge pull request #1490 from keboola/jirka/dmd-105-test-im-of-tables…

77e4f99

…-from-standard-external-buckets DMD-105 test im of tables from standard external buckets

PAT-178 string codes improvements

b11abc0

Merge pull request #1485 from keboola/zajca/pat-178/ws-keypair-refactor

b2cce76

PAT-248 new test testWorkspaceKeyPairRotation

92c8f15

PAT-248 new method setPublicKey

53d639d

PAT-248 add api docs

1a6bdf4

Merge pull request #1495 from keboola/zajca/pat-248/ws-keypair-rotation

1a7c6e1

github-actions bot removed the tag-e2e label Sep 16, 2025

zajca force-pushed the zajca/dmd-375/ro-storage-branches branch 3 times, most recently from 4518b92 to 76d3ae7 Compare September 16, 2025 12:35

zajca added the tag-e2e label Sep 16, 2025

github-actions bot removed the tag-e2e label Sep 16, 2025

zajca added the tag-e2e label Sep 16, 2025

github-actions bot removed the tag-e2e label Sep 16, 2025

zajca force-pushed the zajca/dmd-375/ro-storage-branches branch from 76d3ae7 to 1aced60 Compare September 16, 2025 12:42

fix messages assertions

e4900d5

zajca force-pushed the zajca/dmd-375/ro-storage-branches branch from f1d929a to 85217ad Compare September 17, 2025 05:14

jirkasemmler and others added 4 commits September 17, 2025 08:09

Merge pull request #1571 from keboola/zajca/fix-dot

b0bfd6d

fix messages assertions

feat(table profiling): Token in response

b0da3fe

- DMD-285 - "Profiled by" token in profiling response.

feat(table profiling): Add "DataSizeTableMetric" for Snowflake

64ec00b

- DMD-285 - Add metric test because there was no "DataSizeTableMetric" available for Snowflake before.

feat(table profiling): Latest drivers with numeric statistics

4bb4d52

- DMD-285

zajca requested a review from jirkasemmler September 19, 2025 13:54

zajca force-pushed the zajca/dmd-375/ro-storage-branches branch from e544e7b to 1371fc9 Compare September 19, 2025 13:55

jirkasemmler requested changes Sep 19, 2025

View reviewed changes

martinsifra and others added 5 commits September 23, 2025 15:52

Merge pull request #1541 from keboola/ms/dmd-285-profiling-metrics

aee7a85

DMD-285 profiling metrics

add new suite paratest-snowflake-real-storage

e78d8ae

allow use of custom workspace client in initTestWorkspace

d573b51

renames suite paratest-snowflake-storage-branches

ba678d6

add missing test case about visibility of bucket between dev branches

4686520

zajca force-pushed the zajca/dmd-375/ro-storage-branches branch from 1371fc9 to 4686520 Compare September 30, 2025 18:41

zajca requested a review from jirkasemmler September 30, 2025 18:41

jirkasemmler approved these changes Sep 30, 2025

View reviewed changes

zajca force-pushed the master branch from 2534779 to 629ec09 Compare October 13, 2025 18:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DMD-375 add new suite paratest-snowflake-real-storage#1569

DMD-375 add new suite paratest-snowflake-real-storage#1569
zajca wants to merge 4878 commits intomasterfrom
zajca/dmd-375/ro-storage-branches

zajca commented Sep 16, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 16, 2025

Uh oh!

github-actions bot commented Sep 16, 2025

Uh oh!

github-actions bot commented Sep 16, 2025

Uh oh!

jirkasemmler left a comment

Uh oh!

jirkasemmler Sep 19, 2025

Uh oh!

jirkasemmler Sep 19, 2025

Uh oh!

zajca Sep 30, 2025

Uh oh!

jirkasemmler Sep 19, 2025

Uh oh!

zajca Sep 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

zajca commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Release

Uh oh!

github-actions bot commented Sep 16, 2025

Uh oh!

github-actions bot commented Sep 16, 2025

Uh oh!

github-actions bot commented Sep 16, 2025

Uh oh!

jirkasemmler left a comment

Choose a reason for hiding this comment

Uh oh!

jirkasemmler Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

jirkasemmler Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

zajca Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

jirkasemmler Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

zajca Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

zajca commented Sep 16, 2025 •

edited

Loading