Adds max-word-length as argument to script#21
Open
osilkin98 wants to merge 1 commit intokarpathy:masterfrom
Open
Adds max-word-length as argument to script#21osilkin98 wants to merge 1 commit intokarpathy:masterfrom
osilkin98 wants to merge 1 commit intokarpathy:masterfrom
Conversation
Signed-off-by: Oleg <16809287+osilkin98@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the makemore series, the max word length for the basic MLP was 3, which was nice because you could tune hyperparameters much quicker.
The current implementation simply calculates the maximum length of an item and uses that as the maximum block size.
This update simply allows users to provide a
--max-word-lengthargument if they want to be able to still use 3, 8, or some other arbitrary value.Signed-off-by: Oleg 16809287+osilkin98@users.noreply.github.com