Open
Conversation
Author
|
With current version app using Ember 4 have an error when rendering code using this addon (see https://github.com/johno/ember-linkify/blob/master/addon/helpers/linkify.js#L10) It seems we have this error because we are using in this addon an old version (v6.6) of ember-cli-babel, see warning message from Ember when building the app consuming this addon cc @johno, if you could have a look / publish a release containing the update to Ember 4 🙏 |
|
@johno Is this still being maintained? Would love to see some ember 4 support. Thank you @ndekeister-us |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade to Ember 4
run ember-cli-update --to 4.4.0README.md(some content has been automatically moved toCONTRIBUTING.md)tests/dummy/app/templates/application.hbs(text inhtag)npm installto updatepackage-lock.jsonyarn lint:fixAlso fix

htmlSafeimport, it is now available in@ember/template, importing it from@ember/stringwill result in this error on production build ->