[WIP] Issue 17 - Punctuation delimited url list#28
Open
kamikaz1k wants to merge 3 commits intojohno:masterfrom
Open
[WIP] Issue 17 - Punctuation delimited url list#28kamikaz1k wants to merge 3 commits intojohno:masterfrom
kamikaz1k wants to merge 3 commits intojohno:masterfrom
Conversation
added 3 commits
April 20, 2017 19:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #17 I thought I would try adding in an option to pass in custom delimiters parsing a URL list.
The solution I am proposing is simply replacing the tail pattern in the original RegEx (
(?:\/\S*)) with a character set pattern ([a-z0-9\-._~:/?#%[\]@!$&'()*+;=,"]`). This then allows me to read the RegExp source and simply splice out the value we want to use as a delimiter.What it doesn't handle is multiple delimiters because I am using the
String.prototype.replacemethod with string arguments. I thought it was overkill so I didn't try to make it work.For reference, I pulled the allowable character set from this SO answer.