adding exact phrase checkbox to search form#433
Open
wcaleb wants to merge 3 commits intojgm:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes add a parameter that allows users to search for exact phrases in the filestore, which is especially desirable when searching for things like page titles that appear in other pages.
I also added a checkbox in the sitenav template to make the feature more visible, but can remove that checkbox if desired, and leave the URL parameter in place.
You can test the feature on this wiki. It may be worth noting that this will probably require additional changes to the
search.jshighlighting script in order for its behavior to work as expected for exact phrase searches versus keyword searches.