FIX RoomId error Refactor and enhance Netatmo refresh logic#27
Merged
zoic21 merged 1 commit intojeedom:betafrom Jan 2, 2026
Merged
FIX RoomId error Refactor and enhance Netatmo refresh logic#27zoic21 merged 1 commit intojeedom:betafrom
zoic21 merged 1 commit intojeedom:betafrom
Conversation
Refactored the refreshClassNetatmo method for improved readability and maintainability. Added explicit handling for modules without room_id, improved error handling, and clarified logic for updating equipment commands. The changes also ensure better mapping between modules and rooms and add debug logging for modules missing room_id.
zoic21
approved these changes
Sep 30, 2025
Salvialf
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue from support :
https://enoxa.groovehq.com/tickets/129797?channel=ch_6216030697&folder=fol_8381928800&orderBy=newestByCollaborator&type=mailbox
Refactored the refreshClassNetatmo method for improved readability and maintainability. Added explicit handling for modules without room_id, improved error handling, and clarified logic for updating equipment commands. The changes also ensure better mapping between modules and rooms and add debug logging for modules missing room_id.
Description
Suggested changelog entry
Related issues/external references
Fixes #
Types of changes
PR checklist