Skip to content

fix: member cards consistent styling#83

Merged
jbloom merged 1 commit intomainfrom
wp/add-will-fix
Mar 1, 2026
Merged

fix: member cards consistent styling#83
jbloom merged 1 commit intomainfrom
wp/add-will-fix

Conversation

@wperlichek
Copy link
Contributor

@wperlichek wperlichek commented Mar 1, 2026

I was looking at the deployed site and noticed my card was a bit thinner when I decreased the window size. Notice in the screenshot below that my card is just a bit thinner because I hardcoded the width previously. I did a fair bit of UI work years ago and this was bugging me 🙂

I think overall, how this was set up before, we had different styling settings for sections with >= 3 members, 1 team member, and 2 members. It doesn't really make sense to me, it looks like it's sort of an artifact of the past. I think the styling rules should be applied to all containers the same no matter how many members are there.

I think this is consistent and cleaner and we won't have to worry about messing with these styling any longer for any sections or team members we add.

Before this fix (deployed now)

image

After this fix (locally):

image

Smoke test LGTM:

image

@netlify
Copy link

netlify bot commented Mar 1, 2026

Deploy Preview for delicate-starship-6bdc01 ready!

Name Link
🔨 Latest commit d55d58b
🔍 Latest deploy log https://app.netlify.com/projects/delicate-starship-6bdc01/deploys/69a496bb50d4800008074059
😎 Deploy Preview https://deploy-preview-83--delicate-starship-6bdc01.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@wperlichek wperlichek requested a review from jbloom March 1, 2026 19:50
Copy link
Member

@jbloom jbloom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, @wperlichek.

Honestly, this sort of webpage styling is above my knowledge level, but the preview looks good and your description of the fix makes sense.

@jbloom jbloom merged commit 3e33040 into main Mar 1, 2026
5 checks passed
@jbloom jbloom deleted the wp/add-will-fix branch March 1, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants