Escape % to avoid "invalid capture index problem" when % in the input#410
Open
ilan-schemoul wants to merge 1 commit intojackMort:mainfrom
Open
Escape % to avoid "invalid capture index problem" when % in the input#410ilan-schemoul wants to merge 1 commit intojackMort:mainfrom
ilan-schemoul wants to merge 1 commit intojackMort:mainfrom
Conversation
This was referenced Mar 19, 2024
Author
|
@jackMort any feedback ? |
|
I am facing this issue as well, in Go it deletes % from formatted strings and gives me completely nonsense answers. Do you have a workaround? |
|
I just pulled your branch and used it and it's fixed :) Thanks so much, I hope this PR gets merged soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
If you select a line with a "%" for example
" while (fscanf(src, "%30s ", str) == 1) "
And try to run a ChatGPTRun command such as code_readbility_analysis you will have an error invalid capture index lua/chatgpt/flows/actions/chat/init.lua:52
The reason it happens is that when there is a % it is interpreted as a capture index by gsub but of course it is not intended. We need to escape those.
The resulting code is value = value:gsub("%%", "%%%%") because inside a string the % themselve need to be escaped too.
It it tested and fix the problem on my side.
PS : I had to close previous PR because I made commit from other PRs mistakenly