Fix unified_tracer.h and add info in README.md so onetrace can be built successfully for Windows#44
Fix unified_tracer.h and add info in README.md so onetrace can be built successfully for Windows#44alex-ayu1 wants to merge 2 commits intointel:masterfrom
Conversation
Added #define NOMINMAX so Windows' WinDef.h will not define the min/max macros.
Added info about <opencl_icd_lib_path> and downloading git and setting up proxy so the onetrace tool can be built successfully.
|
@vladimir-tsymbal @jfedorov Can you please help to review this PR? I helped Alex and fixed the Windows build with the changes in this PR and Alex raised this PR to help us, but we need a third pair of eyes to review it before merging. |
vladimir-tsymbal
left a comment
vladimir-tsymbal
left a comment
There was a problem hiding this comment.
We should not ask user to look at Windows Registry Editor. Any reference to Registry Editor should be removed. Best approach is to refer to MSFT documentation.
OpenCL version and path to dll can be found via Computer Management->Device Manager->Display Adapters->Properties->Driver->Driver Details.
What is the purpose of asking to install git? It's supposed to be the case by default, or at least it should be explained by which reason one needs to install it.
Another note. Why mentioning proxy for git? It's not required outside corporate networks.
jfedorov
left a comment
jfedorov
left a comment
There was a problem hiding this comment.
@zma2 , @alex-ayu1 Apologies for responding in such a delay.
At the moment - we do not accept PRs into this repo. Please,
- either open an issue
- work offline and submit PR into Intel internal repo.
* Report summary stats after L0 collector is destructed * Combine the two checks and fix a typo
4 participants
onetrace cannot be built due to an error in unified_tracer.h, and the lacking of information on how to build the tool for Windows makes the building process difficult. Fixed unified_tracer.h and added more necessary information in README.md to make the built process smoother.