Open
Conversation
- Add --local flag to run_benchmark.py to run benchmarks locally without SSH connection to remote embedded device - Add local execution functions: local_compile_cmake_project(), local_run_program(), local_run_trace_conversion() - Add --local and --select flags to experiment_timing.py - Make credentials.py import conditional (only for remote mode) - Add Dockerfile with all dependencies for running benchmarks - Add docker-compose.yml for convenience - Add GitHub Actions CI workflow for local benchmark testing - Update .gitignore to exclude generated data/include directories Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
trace_to_csv and trace_to_chrome need to be built from reactor-c before running benchmarks. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Only install trace_to_csv and trace_to_chrome, skip trace_to_influxdb which requires libcurl. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
@copilot please review this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for running timing benchmarks locally without connecting to a remote embedded device, along with Docker support for reproducible environments.
Changes
Benchmark Scripts:
--local(-l) flag torun_benchmark.pyto run benchmarks locallylocal_compile_cmake_project(),local_run_program(),local_run_trace_conversion()--localand--selectflags toexperiment_timing.pycredentials.pyimport conditional (only required for remote mode)Docker Support:
Dockerfilewith all dependencies (Java 17, Python, CMake, RISC-V toolchain, Verilator, etc.)docker-compose.ymlfor convenienceCI:
Test plan
run_benchmark.py --local --select=PingPonglocallyexperiment_timing.py --local --select=PingPonglocally (all 3 schedulers: NP, LB, EGS)Usage
🤖 Generated with Claude Code