Skip to content

Add useLinkedAvatar config#209

Open
stackpan wants to merge 2 commits intohypherionmc:universalfrom
stackpan:use-linked-avatar-config-separation
Open

Add useLinkedAvatar config#209
stackpan wants to merge 2 commits intohypherionmc:universalfrom
stackpan:use-linked-avatar-config-separation

Conversation

@stackpan
Copy link

Hi, I just added useLinkedAvatar config to separate useLinkedName that display account name and avatar in Discord.

I tested it and it works fine in webhook mode since the custom avatar only works in that mode.

Feel free to improve my code changes for more clean.

useLinkedAvatar = true
image

useLinkedAvatar = false
image

@hypherionmc
Copy link
Owner

Hey. Thanks for the PR.

It looks good, but just one thing, please increment the config version number under SDLinkConfig as well. This just ensures the option is added to the config files properly and doesn't result in NPE's

@stackpan
Copy link
Author

There you go, I've increased the version number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants