fix: guard formatNumber against non-numeric values #1721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When table columns contain non-numeric values (strings, etc.) and a number format like Percent is applied, the formatting produces NaN because `numbro()` can't parse strings. The existing falsy check (`!value && value !== 0`) doesn't catch non-empty strings since they're truthy. Adds a `typeof` and `isNaN` guard to return the raw value as-is when it's not actually numeric. Fixes hyperdxio#1510
|
|
@themavik is attempting to deploy a commit to the HyperDX Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1510
Root cause: When a number format (e.g., Percent) is applied to table columns that contain non-numeric values,
formatNumberdoesn't catch non-empty strings.numbro()then produces NaN.The existing check
!value && value !== 0catchesnull,undefined, andNaN, but NOT non-empty strings (which are truthy and pass through tonumbro()).Changes
packages/app/src/utils.ts: Addedtypeof value !== 'number' || isNaN(value)guard that returns the raw value as a string instead of formatting it.Risk Assessment
Low - Only adds a guard for an edge case. Numeric values are formatted exactly as before.