Skip to content

Conversation

@teeohhem
Copy link
Contributor

@teeohhem teeohhem commented Feb 6, 2026

No description provided.

@vercel
Copy link

vercel bot commented Feb 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview, Comment Feb 6, 2026 7:39pm

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2026

⚠️ No Changeset found

Latest commit: fe2822d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@claude
Copy link

claude bot commented Feb 6, 2026

Code Review

No critical issues found.

The change simplifies the test result checking logic by replacing JavaScript with shell script, which is appropriate for this use case. The logic correctly:

  • Aggregates failure counts from all shards using jq
  • Fails the job when tests fail (exit 1)
  • Falls back to checking the parent job status (needs.e2e-tests.result) to catch failures even if artifacts are missing

The implementation is sound and the fallback check at line 283-286 is a good safety net.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

E2E Test Results

All tests passed • 63 passed • 4 skipped • 819s

Status Count
✅ Passed 63
❌ Failed 0
⚠️ Flaky 1
⏭️ Skipped 4

Tests ran across 4 shards in parallel.

View full report →

@teeohhem teeohhem marked this pull request as ready for review February 6, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants