Add a Github Actions Workflow for integration testing#386
Open
Add a Github Actions Workflow for integration testing#386
Conversation
Working towards #346
gcapes
requested changes
May 21, 2025
Collaborator
gcapes
left a comment
There was a problem hiding this comment.
This is a good step in the right direction. I'm not sure how to test this but I can see a couple of issues/improvements:
- This is pulling workflows from another repo. I think they should live within the MatFlow repo. Indeed the groups one already does, and could be extracted from inline code to a separate code file which I guess could then be run by this action?
- The
hello.yamlworkflow uses a python script and needs a full path to it. https://github.com/LightForm-group/matflow-user-documentation/blob/master/hello.yaml#L22. I'm not sure how you get round that but again perhaps if it was a part of the matflow repo, then after cloning in the action, we could specify a path? I can't think of a nice implementation but I guess you could do something withsedto replace the file path?
Collaborator
Author
|
I've raised that path problem as a bug. I'll have a think about how to hack it... though I don't like that! |
Collaborator
Author
|
Surgery, thy name is PERL! run: |
perl -pi -e 's/$ENV{REPLACE}/$ENV{PWD}/g' *.yaml
working-directory: userdocs
env:
REPLACE: /home/mbexegc2/projects/lightform/matflow-user-documentation |
Collaborator
Author
|
And with that change, we now have the integration test of (some of) the user documentation workflows working. |
Collaborator
Author
|
@gcapes My intention would be to add more bits to this to test other key workflows. The one that exists explicitly is to test the user documentation repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working towards #346
Currently this just runs the
helloandgroupsworkflows fromLightForm-group/matflow-user-documentation.