Fix error EUNKNOWN on 204 response#53
Open
abemedia wants to merge 1 commit intoholidayextras:masterfrom
Open
Conversation
All empty responses return a 500 EUNKNOWN error, the jsonapi spec however states that 204 responses are a valid response for POST, PATCH & DELETE requests where the result matches the request body. Here an excerpt from the spec on http://jsonapi.org/format/ ``` A server MUST return a 204 No Content status code if an update is successful and the representation of the resource in the request matches the result. ```
Author
|
Just checked the logs on travis and the fail was not a fault of the code! |
Contributor
|
@abemedia: I've rerun the build. I'll try to review the PR soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All empty responses return a 500 EUNKNOWN error, the jsonapi spec however states that 204 responses are a valid response for POST, PATCH & DELETE requests where the result matches the request body. Here an excerpt from the spec: