Proposed changes to accompany the SCL service loader change #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbynek
reviewed
Jan 4, 2026
| The `-noserver` option instructs development mode to not start the embedded Jetty instance. In its place, you would run the J2EE container of your choice and simply use that | ||
| in place of the embedded Jetty instance. | ||
| GWT provides several ways to customize the development experience to suit your application's needs: | ||
| * The simplest and most flexible option is to use CodeServer instead of DevMode, allowing you to run your own application server, and only rely on GWT to |
Contributor
There was a problem hiding this comment.
Should we use backticks for all Java class names in this paragraph (CodeServer, DevMode, ServiceLoader)?
zbynek
reviewed
Jan 4, 2026
| ### Using EJBs in development mode<a id="using_EJBs_in_development_mode"></a> | ||
| GWT provides the `-noserver` option to the development mode shell script for this sort of thing. | ||
| ### Customizing the development experience<a id="customizing_the_development_experience"></a> |
Contributor
There was a problem hiding this comment.
The new section and the removed section should be reflected in the TOC on top of this file.
zbynek
reviewed
Jan 5, 2026
| * It is also possible to pass `-noserver` to DevMode, which still keeps the GUI of DevMode, but with no extra server started. The command line argument to | ||
| configure the path to write compiled JS is also `-war`. | ||
| * Finally, you can supply a custom server implementation to DevMode. The class must extend `ServletContainerLauncher`, and may be registered for a | ||
| ServiceLoader to pick it up with that same name. If it is the only service loaded instance, it will be used automatically - otherwise, it may be specified |
Contributor
There was a problem hiding this comment.
"with that same name" is a bit unclear (same as what?), maybe omit that since the next sentence explains it (?)
Is it worth mentioning that getName() must return a string only containing alphanumeric characters for selection by nameto work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.