feat: Implement AbstractAsyncFeatureCache for async SDK clients#80
Open
vazarkevych wants to merge 8 commits intomainfrom
Open
feat: Implement AbstractAsyncFeatureCache for async SDK clients#80vazarkevych wants to merge 8 commits intomainfrom
vazarkevych wants to merge 8 commits intomainfrom
Conversation
…tureRepository, integrate async cache into load_features_async
# Conflicts: # growthbook/growthbook.py
# Conflicts: # growthbook/growthbook.py
# Conflicts: # growthbook/growthbook.py
madhuchavva
requested changes
Feb 5, 2026
| class FeatureRepository(object): | ||
| def __init__(self) -> None: | ||
| self.cache: AbstractFeatureCache = InMemoryFeatureCache() | ||
| self.async_cache: Optional[AbstractAsyncFeatureCache] = None |
Contributor
There was a problem hiding this comment.
Setting an async cache in the sync feature repo implementation isn't ideal. We could rather override the methods in EnhancedFeatureRepository which is used by the async client and leave the super class untouched, so we keep the sync vs async executions isolated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces asynchronous feature caching support, which is critical for the asynchronous operation mode of the SDK (
GrowthBookClient). Utilizing an async cache (e.g., Redis) significantly reduces latency and API load by eliminating the need for HTTP requests during a Cache HIT.Changes
AbstractAsyncFeatureCache: Defined the interface for asynchronous caching, including methods likeget(key),set(key, value, ttl).FeatureRepository: Theload_features_asyncmethod now utilizesself.async_cache(if provided inOptions) to check and store features in the cache.