New Feature proposal: Partial registering and unregistering#471
Open
danielaRiesgo wants to merge 1 commit intogreenrobot:masterfrom
Open
New Feature proposal: Partial registering and unregistering#471danielaRiesgo wants to merge 1 commit intogreenrobot:masterfrom
danielaRiesgo wants to merge 1 commit intogreenrobot:masterfrom
Conversation
Owner
|
Thanks. Well, we had a feature for registering only certain event types before and kicked it out for simplicity. You can still have a inner class for example to receive specific event classes only... |
Author
|
Yes, but I think it's not good to change your structure creating new virtual classes to adapt yourself to what you would want the framework to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR proposes a registering and unregistering of a subscriber specifically for certain event types.
I think this will help with certain cases were you want to stop listening to some event without stop listening to all the other events, or start listening to some event only after something happens. For example, when you need to make a request to the server but you don't have internet, and so you want to start hearing an InternetConnection event or something that tells you when the internet is back on, so that you can make that request. But after you've done that request, you don't need to keep listening at all.
Hope you find it useful too.
By the way, I had to do what the
fix-empty-test-suitebranch said to make the tests run.