Update Android build dependencies#400
Open
friederbluemle wants to merge 5 commits intogreenrobot:masterfrom
Open
Update Android build dependencies#400friederbluemle wants to merge 5 commits intogreenrobot:masterfrom
friederbluemle wants to merge 5 commits intogreenrobot:masterfrom
Conversation
38a701e to
bf0025c
Compare
bf0025c to
cc45266
Compare
cc45266 to
b3f1112
Compare
Collaborator
|
Thanks for your efforts, but we generally update dependencies ourselves when necessary. -ut |
Contributor
Author
|
@greenrobot-team No worries.. Anything problematic or any concerns you see with this PR? I could split it up into more than one PR if that helps. |
b3f1112 to
2ffa42e
Compare
Contributor
Author
|
Commits amended and PR updated with latest versions Gradle wrapper |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates build tools to
25.0.2, Gradle wrapper to3.4.1, and the plugin to2.3.0(latest versions as of Mar 23, 2017)It also replaces
android-aptwith the native Gradle directive for annotation processing (this is now possible with a more recent version of Gradle. No need for a custom plugin anymore).Note that it also re-adds the default
gradle.propertiesfile. This file should be under version control to set project-wide settings (e.g. java heap space). Without increasing the max heap space, dex would run out-of-process, slowing down the build (and generating a warning).It also removes the hard-coded Java 7 statements from EventBusTest. This is not necessary and even results in an error with the latest build tools (Java 8 is required).
Please NO GitHub rebase/squash merges. If you'd like me to combine some or all of the commits, please let me know, and I will update my branch. Thank you.