[Draft] feat: add support for setting generated step images type on android #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illuminati1911
force-pushed
the
feat/generated-step-images-type
branch
from
aef3aa0 to
4ecfa9e
Compare
jokerttu
reviewed
Dec 8, 2025
jokerttu
reviewed
Dec 8, 2025
illuminati1911
force-pushed
the
feat/generated-step-images-type
branch
from
4ecfa9e to
db5c76a
Compare
jokerttu
reviewed
Dec 17, 2025
| } | ||
|
|
||
| private fun convertNavInfoStepInfo(stepInfo: StepInfo): StepInfoDto { | ||
| fun convertManeuverToHash(maneuver: Int): String { |
Contributor
There was a problem hiding this comment.
I don't think we need SHA-256 here, as there is no security reasons for that.
Maybe no hash at all. like "m_$maneuver" as a key?
It should be unique for all maneuvers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for setting generated step images type on Android
Closes: #534
Pre-launch Checklist