Fix/least privilege monitoring role #431
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refines the IAM permissions granted to the service account in the Workload Identity Federation setup script. The `roles/monitoring.editor` role has been replaced with the more restrictive `roles/monitoring.metricWriter` role. This change adheres to the principle of least privilege, ensuring the service account has only the necessary permissions to write metric data to Cloud Monitoring, thereby enhancing the security of the setup. The user-facing output in the script has also been updated to accurately reflect this change.
nssuwan186-dev
requested review from
R2wenD2,
adamfweidman,
haroonc and
prithpal
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
@gemini-cli /review |
Contributor
|
🤖 Hi @parthasaradhie, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.