Skip to content

Eliminating redefined constant, restructuring "earth" package and distributing methods #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benguild wants to merge 10 commits into from
Closed

Eliminating redefined constant, restructuring "earth" package and distributing methods #239

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2224cdf
Eliminating redefined constant
benguild Nov 29, 2025
9a32909
Restructuring "earth" package and distributing methods
benguild Nov 29, 2025
cd7a781
Removing debatable constant checks
benguild Nov 29, 2025
04f78a1
Code cleanup
benguild Nov 29, 2025
1a532bd
Adding check from "TestKmToAngle(…)"
benguild Nov 29, 2025
377702c
Code cleanup
benguild Nov 29, 2025
4ad4a85
Reducing verbosity
benguild Nov 29, 2025
09c1534
Switching from "radiusKm" to units
benguild Nov 30, 2025
72a2f11
Renaming method for clarity
benguild Nov 30, 2025
e111fcd
Renaming variable for clarity
benguild Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions s2/s2_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import (
"math/rand"
"os"

"github.com/golang/geo/earth"
"github.com/golang/geo/r1"
"github.com/golang/geo/r2"
"github.com/golang/geo/s1"
Expand Down Expand Up @@ -74,8 +75,7 @@ func float64Near(x, y, ε float64) bool {
return math.Abs(x-y) <= ε
}

// The Earth's mean radius in kilometers (according to NASA).
const earthRadiusKm = 6371.01
var earthRadiusKm = earth.Radius.Kilometers()

// kmToAngle converts a distance on the Earth's surface to an angle.
func kmToAngle(km float64) s1.Angle {
Expand Down
Loading