Skip to content

Conversation

@joshuarli
Copy link
Member

@joshuarli joshuarli commented Dec 22, 2025

we have not enforced coverage in any way (not a required check) for backend commits, and afaict coverage data is not used anywhere

deleting coverage + codecov upload shaves off 1m30s from all shards and reduces total wall test time by 40 minutes:

random master commit https://github.com/getsentry/sentry/actions/runs/20431363995/usage
removed coverage https://github.com/getsentry/sentry/actions/runs/20442672030/usage

@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Dec 22, 2025
@github-actions
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@joshuarli joshuarli marked this pull request as ready for review December 23, 2025 17:48
@joshuarli joshuarli requested review from a team as code owners December 23, 2025 17:48
@joshuarli joshuarli merged commit b1eafac into master Dec 23, 2025
70 checks passed
@joshuarli joshuarli deleted the delete-coverage branch December 23, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants