feat(explorer): share chat links #105376
Open
feat(explorer): share chat links #105376
+223
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
❌ 9 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Member
Author
|
@cursoragent review |
Contributor
|
Unable to authenticate your request. Please make sure to connect your GitHub account to Cursor. Go to Cursor |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| const parsedRunId = Number(paramValue); | ||
| if (!Number.isNaN(parsedRunId)) { | ||
| openExplorerPanel(); | ||
| setRunId(parsedRunId); |
Contributor
There was a problem hiding this comment.
Zero or empty runId opens panel without loading data
When the URL contains ?explorerRunId=0 or ?explorerRunId= (empty value), Number() returns 0, which passes the !Number.isNaN(parsedRunId) check. This causes openExplorerPanel() to be called and runId to be set to 0. However, since !!0 evaluates to false, the API query's enabled condition (!!runId && !!orgSlug) is not satisfied, so no data is fetched. The result is the panel opens in an empty state with no error feedback to the user. Adding a validation for parsedRunId > 0 would prevent this confusing behavior.
Member
Author
There was a problem hiding this comment.
think this is ok, people shouldn't be making links w these values. I tested the behavior when run id doesn't exist (api fails) or api doesn't run - the panel just renders as blank. Can iterate on error states later (made a ticket)
Member
Author
|
requires https://github.com/getsentry/seer/pull/4345 to disable editing for other teammates. We can also do that as a followup. At this stage of the feature, I have no problem allowing all teammates to edit a chat, the only thing is we'll have undefined behavior when 2 people send chat requests at the same time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows opening other chats from your org on any page, with the query param
?explorerRunId. Adds a top bar button to copy link to current chat.Other users' chats won't appear in session history and can only be reopened through a link when closed. At the moment all members with explorer access can edit/continue the chat. This is fine IMO but there are no guards for parallel chat requests (this is a problem for experimental autofix too). The quickest way to deal w this is to make chats read-only for everyone except the original user - handling parallel requests is a larger, separate scope