Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| Every Sentry event includes an `ota_updates` context with the current update state: | ||
|
|
||
| | Field | Description | | ||
| |---|---| |
There was a problem hiding this comment.
nit/q: Are is_enabled, is_using_embedded_assets, and emergency_launch_reason omitted for simplicity?
antonis
left a comment
antonis
left a comment
There was a problem hiding this comment.
LGTM 🚀
Left a nit/q but feel free to ignore if the omission was intentional
There was a problem hiding this comment.
Thank you for the PR!
My only question is the same one as the one made here https://github.com/getsentry/sentry-docs/pull/16923/changes/BASE..bbdda9c5920c74950643e3b6601e3fbe81cd9c80#r2929948842
| **`eas-build-on-error`** — Sends an `EASBuildError` event to Sentry when a build fails. The event includes: | ||
|
|
||
| - Build platform (`ios` / `android`) | ||
| - Build profile (for example, `production`, `preview`) |
There was a problem hiding this comment.
Sorry I'm not super familiar with expo builds, is this the same thing as the build environment?
There was a problem hiding this comment.
Very similar, yes: https://docs.expo.dev/build/eas-json/#build-profiles
coolguyzone
left a comment
coolguyzone
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for the big lift 💪
We've recently added a bunch of changes to Expo integrations in the React Native SDK, this PR adds the missing information about those changes to the docs. Here is the list of PRs it covers: - Expo Updates - getsentry/sentry-react-native#5794 - getsentry/sentry-react-native#5788 - getsentry/sentry-react-native#5748 - Expo Config Plugin - getsentry/sentry-react-native#5796 — 06d4e245 — Add environment option to Expo config plugin - EAS Build Integration - getsentry/sentry-react-native#5666 - getsentry/sentry-react-native#5773 - getsentry/sentry-react-native#5617 - Expo Router / Tracing - getsentry/sentry-react-native#5606 - getsentry/sentry-react-native#5718 - Tooling / Fixes - getsentry/sentry-react-native#5636 - getsentry/sentry-react-native#5733
4 participants
We've recently added a bunch of changes to Expo integrations in the React Native SDK, this PR adds the missing information about those changes to the docs.
Here is the list of PRs it covers:
environmentoption to Expo config plugin sentry-react-native#5796 — 06d4e245 — Add environment option to Expo config plugin