Fix Implicitly marking parameters TransactionalEmailsApi.php on php 8.4#51
Open
fabricebegue wants to merge 6 commits intogetbrevo:mainfrom
Open
Fix Implicitly marking parameters TransactionalEmailsApi.php on php 8.4#51fabricebegue wants to merge 6 commits intogetbrevo:mainfrom
fabricebegue wants to merge 6 commits intogetbrevo:mainfrom
Conversation
Message log : Deprecated: Brevo\Client\Api\TransactionalEmailsApi::__construct(): Implicitly marking parameter $client as nullable is deprecated, the explicit nullable type must be used instead in /var/www/app/vendor/getbrevo/brevo-php/lib/Api/TransactionalEmailsApi.php on line 72
Deprecated implicitly marking parameter
Deprecated implicitly marking parameter
Deprecated implicitly marking parameter
Deprecated implicitly marking parameter
Deprecated implicitly marking parameter
|
|
This pull request should be accepted in order to migrate to PHP 8.4 |
|
how can we get this merged, please advise on the process - this is creating a lot of noise in our log files |
|
This PR should fix #57. But as stated by @LaurentBrieu in the above issue, this fix will break compatibility with PHP < 7.1 and as such, the minimum PHP version should be updated in composer.json and I guess this will require a major release. Much needed indeed! |
|
+1 ! |
|
+1 |
|
+1! |
1 similar comment
|
+1! |
|
@sowmyahora2001 @nik-sib @preetishishodia7 would you please consider merging this, stop supporting PHP 5.6/7.0, and tag a new version? 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On PHP 8.4 when we sent a transactional email, some deprecated messages are log
Message log detail : Deprecated: Brevo\Client\Api\TransactionalEmailsApi::__construct(): Implicitly marking parameter $client as nullable is deprecated, the explicit nullable type must be used instead in /var/www/app/vendor/getbrevo/brevo-php/lib/Api/TransactionalEmailsApi.php on line 72