Fix broken check of valid base64 encoding of attached files#12
Open
matsolastrom wants to merge 2 commits intogetbrevo:mainfrom
Open
Fix broken check of valid base64 encoding of attached files#12matsolastrom wants to merge 2 commits intogetbrevo:mainfrom
matsolastrom wants to merge 2 commits intogetbrevo:mainfrom
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Author
|
@preetishishodia7 can we please merge this? |
Author
|
Ping @preetishishodia7 ? Can this please be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the issue that PHP base64 encoding does not always work with the original preg_match.
Using PHPs own encode and decode functions ensure full compatibility.
This fixes #11