Skip to content

Made MBC3 article a little more clear#648

Open
evanwporter wants to merge 1 commit intogbdev:masterfrom
evanwporter:patch-2
Open

Made MBC3 article a little more clear#648
evanwporter wants to merge 1 commit intogbdev:masterfrom
evanwporter:patch-2

Conversation

@evanwporter
Copy link
Contributor

No description provided.

Copy link
Member

@avivace avivace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not in favor of this change. I believe the original wording is better. As for the MBC1 is more precise here, since the sentence refers specifically to MBC1’s bank-selection behavior rather than a general similarity (which seems to be suggested/implied by the 'with')

Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's the entire point: on this MBC, like on MBC1, a write of $00 maps to Bank 1. I prefer this new wording for that exact reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants