Draft
Conversation
lucat1
changed the title
lucat1
force-pushed
the
simpel-linear-alloc
branch
3 times, most recently
from
c82f6b1 to
328862a
Compare
lucat1
force-pushed
the
simpel-linear-alloc
branch
2 times, most recently
from
aa2fec5 to
13fc551
Compare
…pping issues in simulation
lucat1
force-pushed
the
simpel-linear-alloc
branch
from
13fc551 to
af8a194
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should not be merged.
This is here just if somebody needs to do big consecutive transfers using the C++ simulation and libstf.
This prevents overlapping addresses to be used by the SimpleMemoryAllocator. That would be an issue with the C++ simulation as the C++ allocator will happily reuse freed memory and the memory won't be unmapped from the simulation, causing a userMap request for an already mapped region to vivado that will crash it.