Implicit set --compress when specifying --compress-method#274
Open
Matthijsy wants to merge 2 commits intofox-it:mainfrom
Open
Implicit set --compress when specifying --compress-method#274Matthijsy wants to merge 2 commits intofox-it:mainfrom
Matthijsy wants to merge 2 commits intofox-it:mainfrom
Conversation
twiggler
previously approved these changes
Dec 4, 2025
Contributor
twiggler
left a comment
twiggler
left a comment
There was a problem hiding this comment.
The logic here correctly catches the edge case where a user supplies a method but forgets the boolean flag.
However, from a UX perspective, if the user explicitly supplies --compress-method, their intent is clearly to compress. Instead of raising a ValueError, would it be cleaner to simply infer args.compress = True if a method is present?
(I approved the pr in case you don't want to pursue this any further)
twiggler
force-pushed
the
feature/compress-method-without-compress
branch
from
49f1735 to
9dd1621
Compare
Matthijsy
changed the title
Author
|
Good point, I agree that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When specifying
--compress-methodwithout--compressthe first argument is ignored. This PR adds a quick check to see that you always specify--compresswhen you specify a method. There is no need to specify a method when the compression is not happing.